-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup rework trace #2038
Cleanup rework trace #2038
Conversation
***NO_CI***
Hi @doingnz, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
Automated fixes for code style.
@doingnz there are issues with the code style on the source files. Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that. |
…753-e978-4f0f-a1bf-debb5d71eec6 Code style fixes for nanoframework/nf-interpreter PR#2038
Automated fixes for code style.
@doingnz there are issues with the code style on the source files. Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that. |
…22b-8631-4cc1-9b7f-c32e791db415 Code style fixes for nanoframework/nf-interpreter PR#2038
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice improvement! 💯
Description
Define single method used to TRACE WP headers and replace the copy-paste with single macro to call the method and ensure uniform traced output when debugging WP message exchanges.
Motivation and Context
Uniform trace data that matches data traced by Debugger on PC. Additional data formatting in a way that is easier to read.
How Has This Been Tested?
Turn the TRACE in cmake-varients.json for the target being built by turning on option "NF_WP_TRACE_ALL": "ON",
Build representative ESP32 and STM32 projects.
Screenshots
Types of changes
Checklist: