Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup rework trace #2038

Merged

Conversation

doingnz
Copy link
Contributor

@doingnz doingnz commented Sep 9, 2021

Description

Define single method used to TRACE WP headers and replace the copy-paste with single macro to call the method and ensure uniform traced output when debugging WP message exchanges.

Motivation and Context

Uniform trace data that matches data traced by Debugger on PC. Additional data formatting in a way that is easier to read.

How Has This Been Tested?

Turn the TRACE in cmake-varients.json for the target being built by turning on option "NF_WP_TRACE_ALL": "ON",
Build representative ESP32 and STM32 projects.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed

@nfbot
Copy link
Member

nfbot commented Sep 9, 2021

Hi @doingnz,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Sep 9, 2021

@doingnz there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click doingnz#2, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

doingnz and others added 3 commits September 9, 2021 23:33
…753-e978-4f0f-a1bf-debb5d71eec6

Code style fixes for nanoframework/nf-interpreter PR#2038
Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Sep 9, 2021

@doingnz there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click doingnz#3, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

…22b-8631-4cc1-9b7f-c32e791db415

Code style fixes for nanoframework/nf-interpreter PR#2038
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice improvement! 💯

@josesimoes josesimoes added the Area: Common libs Everything related with common libraries label Sep 9, 2021
@josesimoes josesimoes merged commit 32e6e4b into nanoframework:cleanup-rework--trace Sep 9, 2021
@doingnz doingnz deleted the cleanup-rework--trace branch September 9, 2021 13:07
@doingnz doingnz restored the cleanup-rework--trace branch September 9, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants