-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ADC2 and tidy up #2043
Fix ADC2 and tidy up #2043
Conversation
Make sure WiFi is not inited if disabled
Hi @AdrianSoundy, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
Hi @AdrianSoundy, 😞 You have to make up your mind on how this PR addresses the issue. It either fixes, closes or resolves it. Can't have them all... |
Automated fixes for code style.
@AdrianSoundy there are issues with the code style on the source files. Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that. |
…1-c78e-4b65-bbd4-f7b54f21b83d' into ADC-fix
- Add missing open close brackets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for fixing this. 😄
Description
Tidy up code and fix channel number used for internal ADC2 (ADC1 channels 10 to 19)
Make sure WiFi is not initted if disabled so that ADC2 can work.
Motivation and Context
How Has This Been Tested?
Modified ADC sample
Types of changes
Checklist: