Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ADC2 and tidy up #2043

Merged
merged 6 commits into from
Sep 12, 2021
Merged

Fix ADC2 and tidy up #2043

merged 6 commits into from
Sep 12, 2021

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Sep 11, 2021

Description

Tidy up code and fix channel number used for internal ADC2 (ADC1 channels 10 to 19)
Make sure WiFi is not initted if disabled so that ADC2 can work.

Motivation and Context

How Has This Been Tested?

Modified ADC sample

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Make sure WiFi is not inited if disabled
@nfbot
Copy link
Member

nfbot commented Sep 11, 2021

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@nfbot
Copy link
Member

nfbot commented Sep 11, 2021

Hi @AdrianSoundy,

😞 You have to make up your mind on how this PR addresses the issue. It either fixes, closes or resolves it. Can't have them all...

Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Sep 11, 2021

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click https://github.com/AdrianSoundy/nf-interpreter/pull/35, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

@AdrianSoundy AdrianSoundy added Series: ESP32 Everything related specifically with ESP32 series targets Status: DONE labels Sep 11, 2021
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this. 😄

@josesimoes josesimoes enabled auto-merge (squash) September 12, 2021 14:55
@nanoframework nanoframework deleted a comment from nfbot Sep 12, 2021
@josesimoes josesimoes merged commit 3f56122 into nanoframework:develop Sep 12, 2021
josesimoes added a commit to josesimoes/nf-interpreter that referenced this pull request Sep 29, 2021
@AdrianSoundy AdrianSoundy deleted the ADC-fix branch May 22, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Status: DONE Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For ESP32 Pico, not all ADC channels can be opened
3 participants