Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount and ESP32 System.IO.Filesystem support #2096

Merged
merged 17 commits into from
Oct 11, 2021
Merged

Mount and ESP32 System.IO.Filesystem support #2096

merged 17 commits into from
Oct 11, 2021

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Oct 10, 2021

Description

Added native support for System.IO.Filesystem SD card mounting
Updated System.IO.Filesystem to make it usable for ESP32
Made System.IO.Filesystem standalone in preparation being built without Windows.devices.Storage

Also some comment typos in esp32 ADC controller

Motivation and Context

How Has This Been Tested?

Manual testing with ESP32
Tested mounting and all methods in System.IO.Filesystem for ESP32

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Oct 10, 2021

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Oct 10, 2021

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click https://github.com/AdrianSoundy/nf-interpreter/pull/37, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

@nfbot
Copy link
Member

nfbot commented Oct 10, 2021

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click https://github.com/AdrianSoundy/nf-interpreter/pull/38, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

@nfbot
Copy link
Member

nfbot commented Oct 10, 2021

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click https://github.com/AdrianSoundy/nf-interpreter/pull/39, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

…e-2528-4104-8723-e5f0ed6f27a7' into filesystem-sdcard
@AdrianSoundy
Copy link
Member Author

Sorry i did squash and rebase changes but somehow ended up with 2 branches of same name that got merged and ending up with all the commits. I can redo this PR if required.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this. 👍🏻

I've reverted changes on a couple of files (mostly typos in comments) that were out of scope for this PR.

@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets hacktoberfest-accepted labels Oct 11, 2021
@josesimoes josesimoes enabled auto-merge (squash) October 11, 2021 06:51
@josesimoes
Copy link
Member

Sorry i did squash and rebase changes but somehow ended up with 2 branches of same name that got merged and ending up with all the commits. I can redo this PR if required.

No need for that! Reviewed and waiting to be merged. 😃

@josesimoes josesimoes merged commit 877226b into nanoframework:develop Oct 11, 2021
@AdrianSoundy AdrianSoundy deleted the filesystem-sdcard branch October 11, 2021 11:05
josesimoes added a commit that referenced this pull request Oct 18, 2021
@josesimoes josesimoes mentioned this pull request Oct 19, 2021
14 tasks
josesimoes added a commit that referenced this pull request Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants