Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework CPU GPIO #2144

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Rework CPU GPIO #2144

merged 1 commit into from
Nov 5, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Debounce timeout is now an uint32_t.
  • Update declaration and implementations on all platforms, W.D.Gpio and S.D.GPio.
  • Complete rework of debounce logic on of ESP32.
  • Fix code style issues.
  • Rename pointers.
  • Adjust SDKCONFIG for timer task priority to match other tasks.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Debounce timeout is now an uint32_t.
- Update declaration and implementations on all platforms, W.D.Gpio and S.D.GPio.
- Complete rework of debounce logic on of ESP32.
- Fix code style issues.
- Rename pointers.
- Adjust SDKCONFIG for timer task priority to match other tasks.
@nfbot nfbot added the Type: bug label Nov 5, 2021
@josesimoes josesimoes added Area: Common libs Everything related with common libraries Platform: ESP32 Everything related specifically with ESP32 platform labels Nov 5, 2021
@josesimoes josesimoes merged commit 716f09f into nanoframework:develop Nov 5, 2021
@josesimoes josesimoes deleted the work-879 branch November 5, 2021 08:02
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Platform: ESP32 Everything related specifically with ESP32 platform Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPIO debounce is not working for ESP32
2 participants