Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework code handling ReadLine() #2154

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Fix bug when a string with new line is available straight from the buffer.
  • Fix search for new line chars in buffer.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Fix bug when a string with new line is available straight from the buffer.
- Fix search for new line chars in buffer.
@josesimoes josesimoes added Area: Targets Area: Common libs Everything related with common libraries labels Nov 16, 2021
@josesimoes josesimoes merged commit edffc8d into nanoframework:develop Nov 16, 2021
@josesimoes josesimoes deleted the fix-889 branch November 16, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Area: Targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SerialPort.ReadLine() is not returning the correct string
2 participants