Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework GetHashCode() #2157

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Rework GetHashCode() #2157

merged 1 commit into from
Nov 22, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Computation for Classes now considers heap block address and correct field pointers to return unique and repeatable hash code.
  • On null pointers - from DeReference() - now returns CRC to allow forward computation.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Computation for Classes now considers heap block address and correct field pointers to return unique and repeatable hash code.
- On null pointers - from DeReference() - now returns CRC to allow forward computation.
@josesimoes josesimoes added the Area: Common libs Everything related with common libraries label Nov 22, 2021
@josesimoes josesimoes merged commit 4736fdc into nanoframework:develop Nov 22, 2021
@josesimoes josesimoes deleted the work-892 branch November 22, 2021 17:10
alexxxz1977 pushed a commit to alexxxz1977/nf-interpreter that referenced this pull request Dec 19, 2021
alexxxz1977 pushed a commit to alexxxz1977/nf-interpreter that referenced this pull request Dec 19, 2021
alexxxz1977 pushed a commit to alexxxz1977/nf-interpreter that referenced this pull request Dec 21, 2021
alexxxz1977 pushed a commit to alexxxz1977/nf-interpreter that referenced this pull request Dec 22, 2021
alexxxz1977 pushed a commit to alexxxz1977/nf-interpreter that referenced this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plain Old Class Object not returning Unique Hash Code
2 participants