Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in unreserving GPIO pins for SD Card #2158

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Conversation

AdrianSoundy
Copy link
Member

Description

Not correctly un-reserving SDIO pins when SDCARD disposed

Motivation and Context

How Has This Been Tested?

Run test from issue 894 in loop

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Nov 24, 2021

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click #2159, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

Automated fixes for code style.
@josesimoes josesimoes added the Platform: ESP32 Everything related specifically with ESP32 platform label Nov 24, 2021
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

This pattern is at more places. Wondering if this is not buggy elsewhere...

@josesimoes josesimoes changed the title Fix bug in unreserving GPIO pins Fix bug in unreserving GPIO pins for SD Card Nov 24, 2021
@josesimoes josesimoes merged commit bf2fb00 into develop Nov 24, 2021
@AdrianSoundy AdrianSoundy deleted the AdrianSoundy-patch-1 branch November 24, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: ESP32 Everything related specifically with ESP32 platform Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32 SDCard reinitialize issue
3 participants