Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation on contributions #217

Merged
merged 2 commits into from
Mar 20, 2017

Conversation

josesimoes
Copy link
Member

  • add suggested workflow to contributions working on open issues
  • add missing labels
  • add anchors to some labels
  • correct branch names (master is now the defaul development branch)

Signed-off-by: José Simões jose.simoes@eclo.solutions

- add suggested workflow to contributions working on open issues
- add missing labels
- add anchors to some labels
- correct branch names (master is now the defaul development branch)

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Mar 20, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

Everything seems to be in order.
A human will be reviewing it shortly. 😉

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I would have a little comment, however :
Line #141 : "Push your changes to your fork..." could be placed before point #7, I think.
Creating a PR should clearly come after the changes are pushed to the contributor's fork, shouldn't it ?

(per reviewer suggestion)

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes
Copy link
Member Author

@MikroBusNet makes sense. Done that.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

Copy link
Member

@piwi1263 piwi1263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK as far as I can see.

@josesimoes josesimoes merged commit 0026f06 into nanoframework:master Mar 20, 2017
@josesimoes josesimoes deleted the doc-update-on-up-for-grabs branch March 20, 2017 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants