-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation on contributions #217
Update documentation on contributions #217
Conversation
- add suggested workflow to contributions working on open issues - add missing labels - add anchors to some labels - correct branch names (master is now the defaul development branch) Signed-off-by: José Simões <jose.simoes@eclo.solutions>
Hi @josesimoes, I'm nanoFramework bot. Everything seems to be in order. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I would have a little comment, however :
Line #141 : "Push your changes to your fork..." could be placed before point #7, I think.
Creating a PR should clearly come after the changes are pushed to the contributor's fork, shouldn't it ?
(per reviewer suggestion) Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@MikroBusNet makes sense. Done that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK as far as I can see.
Signed-off-by: José Simões jose.simoes@eclo.solutions