Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build-instructions.md #229

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Update build-instructions.md #229

merged 1 commit into from
Mar 23, 2017

Conversation

techcap
Copy link
Contributor

@techcap techcap commented Mar 23, 2017 •
edited
Loading

Updated build-instructions.md

@nfbot
Copy link
Member

nfbot commented Mar 23, 2017

Hi @techcap,

I'm nanoFramework bot.
Thank you for your contribution!

It seems that the DCO signed-off or an 'obvious fix' mention are missing in the commit(s) message(s).
Please make sure that you've:

  1. Followed the Contribution Workflow.
  2. Signed off the commit(s) following the instructions about the Developer Certificate of Origin or an Obvious Fix mention.

A human will be reviewing it shortly. 😉

josesimoes
josesimoes approved these changes Mar 23, 2017
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine. Thanks for adding this.

Please amend your commit so it includes the DCO with your signoff and this should be good to merge.

@nfbot
Copy link
Member

nfbot commented Mar 23, 2017

Hi @techcap,

It seems that the DCO or 'obvious fix' mention are missing in some of the commit(s) message(s).
Please make sure that you've either signed off the commit(s) following the instructions regarding the Developer Certificate of Origin or added an Obvious Fix mention.

A human will be reviewing this shortly. 😉

@techcap techcap closed this Mar 23, 2017
@techcap techcap deleted the patch-1 branch March 23, 2017 07:28
@techcap
Copy link
Contributor Author

techcap commented Mar 23, 2017

Leave a comment

@techcap techcap restored the patch-1 branch March 23, 2017 07:35
@techcap techcap reopened this Mar 23, 2017
@techcap techcap closed this Mar 23, 2017
@techcap techcap reopened this Mar 23, 2017
@techcap
Updated prerequisites.
cb76249 
Signed-off-by: Bongho Lee <techcap@live.com>
@josesimoes josesimoes merged commit 197ad33 into nanoframework:master Mar 23, 2017
@techcap techcap deleted the patch-1 branch March 23, 2017 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Status: merge OK Type: documentation Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@techcap @nfbot @josesimoes