Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add touch pad support for ESP32 and ESP32-S2/3 #2536

Merged
merged 70 commits into from
Feb 15, 2023
Merged

Conversation

Ellerbach
Copy link
Member

@Ellerbach Ellerbach commented Feb 8, 2023

Description

Add support for ESP32 and ESP32-S2/S3 touch pad support.

Creating this Darft PR to get early feedback on the implementation. Similar PR for the ESP32 hardware on its way.

Motivation and Context

How Has This Been Tested?

Tested on ESP32

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

@Ellerbach Ellerbach changed the title Add touchpin esp32 Add touch pad support for ESP32 and ESP32-S2/3 Feb 9, 2023
@josesimoes josesimoes added Status: in progress Platform: ESP32 Everything related specifically with ESP32 platform and removed Type: documentation labels Feb 10, 2023
@Ellerbach Ellerbach marked this pull request as ready for review February 14, 2023 18:19
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Awesome work with this.
Just fix the declarations and placement of the helper functions (at the bottom of the file) and it's OK to merge.

- Fix missing cmake template when building in AZDO without community targets.

***NO_CI***
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well done. 👍🏻

@josesimoes josesimoes merged commit a9a743f into main Feb 15, 2023
@josesimoes josesimoes deleted the add-touchpin-esp32 branch February 15, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: ESP32 Everything related specifically with ESP32 platform Status: in progress Type: bug Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Touch and Pin Deep Sleep Wakeup Doesn't Work on ESP32
3 participants