-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add touch pad support for ESP32 and ESP32-S2/3 #2536
Conversation
targets/ESP32/_nanoCLR/nanoFramework.Hardware.ESP32/nanoFramework_hardware_esp32_native.cpp
Outdated
Show resolved
Hide resolved
...re.ESP32/nanoFramework_hardware_esp32_native_nanoFramework_Hardware_Esp32_Touch_TouchPad.cpp
Outdated
Show resolved
Hide resolved
...re.ESP32/nanoFramework_hardware_esp32_native_nanoFramework_Hardware_Esp32_Touch_TouchPad.cpp
Outdated
Show resolved
Hide resolved
...re.ESP32/nanoFramework_hardware_esp32_native_nanoFramework_Hardware_Esp32_Touch_TouchPad.cpp
Outdated
Show resolved
Hide resolved
...re.ESP32/nanoFramework_hardware_esp32_native_nanoFramework_Hardware_Esp32_Touch_TouchPad.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!! Awesome work with this.
Just fix the declarations and placement of the helper functions (at the bottom of the file) and it's OK to merge.
targets/ESP32/_nanoCLR/nanoFramework.Hardware.ESP32/nanoFramework_hardware_esp32_native.h
Outdated
Show resolved
Hide resolved
- Fix missing cmake template when building in AZDO without community targets. ***NO_CI***
- Fix missing cmake template when building in AZDO without community targets. ***NO_CI***
- Fix missing cmake template when building in AZDO without community targets. ***NO_CI***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Well done. 👍🏻
Description
Add support for ESP32 and ESP32-S2/S3 touch pad support.
Creating this Darft PR to get early feedback on the implementation. Similar PR for the ESP32 hardware on its way.
Motivation and Context
How Has This Been Tested?
Tested on ESP32
Screenshots
Types of changes
Checklist