Skip to content

Conversation

@CoryCharlton
Copy link
Member

@CoryCharlton CoryCharlton commented Nov 10, 2023

Description

Updating signatures for nanoframework/System.IO.FileSystem#91

Motivation and Context

Required for library updates

How Has This Been Tested?

  • Unit tests
  • On device

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nfbot nfbot added the Type: dependencies Pull requests that update a dependency file(s) or version label Nov 16, 2023
@josesimoes josesimoes merged commit 0e1df34 into nanoframework:main Nov 16, 2023
@CoryCharlton CoryCharlton deleted the refactor_path branch November 16, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: dependencies Pull requests that update a dependency file(s) or version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants