-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESP IDF path to fix Dev Container #2999
Conversation
WalkthroughThe changes update the Dockerfile configurations for the Espressif IoT development framework, enhancing the ESP32 development environment. Key upgrades include shifting from Python version 5.1 to 5.2 and merging the Xtensa toolchain paths, aimed at streamlining the build process. These modifications improve compatibility and simplify the setup for developers working with ESP32. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .devcontainer/All/Dockerfile.All.SRC (1 hunks)
- .devcontainer/ESP32/Dockerfile.ESP32.SRC (1 hunks)
Additional comments not posted (4)
.devcontainer/ESP32/Dockerfile.ESP32.SRC (2)
69-69
: Upgrade to the newer ESP-IDF Python environment approved.The change from
idf5.1_py3.11_env
toidf5.2_py3.11_env
is noted and approved.Ensure that all dependencies and tools are compatible with the new Python environment.
75-75
: Consolidation of Xtensa toolchain paths approved.The change to consolidate the Xtensa toolchain paths is noted and approved.
Ensure that the consolidated path includes all necessary tools for the ESP32 variants.
.devcontainer/All/Dockerfile.All.SRC (2)
139-139
: Consolidation of Xtensa toolchain paths approved.The change to consolidate the Xtensa toolchain paths is noted and approved.
Ensure that the consolidated path includes all necessary tools for the ESP32 variants.
133-133
: Upgrade to the newer ESP-IDF Python environment approved.The change from
idf5.1_py3.11_env
toidf5.2_py3.11_env
is noted and approved.Ensure that all dependencies and tools are compatible with the new Python environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .devcontainer/All/Dockerfile.All.SRC (1 hunks)
Files skipped from review due to trivial changes (1)
- .devcontainer/All/Dockerfile.All.SRC
Description
Change the Path to ESP IDF build binary
Motivation and Context
How Has This Been Tested?
Tested on ESP32, ESP32_S3, ESP32_C3 and ESP32_C6_THREAD
Screenshots
Types of changes
Checklist
Summary by CodeRabbit
New Features
Bug Fixes
These changes facilitate a better development experience and maintain consistency across ESP32 projects.