Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESP IDF path to fix Dev Container #2999

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

alberk8
Copy link
Contributor

@alberk8 alberk8 commented Aug 2, 2024

Description

Change the Path to ESP IDF build binary

Motivation and Context

How Has This Been Tested?

Tested on ESP32, ESP32_S3, ESP32_C3 and ESP32_C6_THREAD

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies/declarations (update dependencies or assembly declarations and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Summary by CodeRabbit

  • New Features

    • Upgraded the Python environment to version 5.2 for improved compatibility with the ESP-IDF.
    • Consolidated toolchain paths, streamlining the setup for ESP32 development.
  • Bug Fixes

    • Resolved path inconsistencies for Xtensa toolchains to enhance the build process.

These changes facilitate a better development experience and maintain consistency across ESP32 projects.

@nfbot nfbot added the Type: bug label Aug 2, 2024
Copy link

coderabbitai bot commented Aug 2, 2024

Walkthrough

The changes update the Dockerfile configurations for the Espressif IoT development framework, enhancing the ESP32 development environment. Key upgrades include shifting from Python version 5.1 to 5.2 and merging the Xtensa toolchain paths, aimed at streamlining the build process. These modifications improve compatibility and simplify the setup for developers working with ESP32.

Changes

Files Change Summary
.devcontainer/All/Dockerfile.All.SRC Updated Python environment path from idf5.1 to idf5.2, consolidated Xtensa toolchain paths.
.devcontainer/ESP32/Dockerfile.ESP32.SRC Replaced Python environment from idf5.1_py3.11_env to idf5.2_py3.11_env, consolidated Xtensa paths.

Assessment against linked issues

Objective Addressed Explanation
Build ESP32 firmware from prebuild Docker image (1524)
Build ESP32 firmware from source (1524)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ce46d49 and 33397d0.

Files selected for processing (2)
  • .devcontainer/All/Dockerfile.All.SRC (1 hunks)
  • .devcontainer/ESP32/Dockerfile.ESP32.SRC (1 hunks)
Additional comments not posted (4)
.devcontainer/ESP32/Dockerfile.ESP32.SRC (2)

69-69: Upgrade to the newer ESP-IDF Python environment approved.

The change from idf5.1_py3.11_env to idf5.2_py3.11_env is noted and approved.

Ensure that all dependencies and tools are compatible with the new Python environment.


75-75: Consolidation of Xtensa toolchain paths approved.

The change to consolidate the Xtensa toolchain paths is noted and approved.

Ensure that the consolidated path includes all necessary tools for the ESP32 variants.

.devcontainer/All/Dockerfile.All.SRC (2)

139-139: Consolidation of Xtensa toolchain paths approved.

The change to consolidate the Xtensa toolchain paths is noted and approved.

Ensure that the consolidated path includes all necessary tools for the ESP32 variants.


133-133: Upgrade to the newer ESP-IDF Python environment approved.

The change from idf5.1_py3.11_env to idf5.2_py3.11_env is noted and approved.

Ensure that all dependencies and tools are compatible with the new Python environment.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@josesimoes josesimoes changed the title Change ESP IDF path to fix Dev Container Fix ESP IDF path to fix Dev Container Aug 2, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 33397d0 and 971a5b7.

Files selected for processing (1)
  • .devcontainer/All/Dockerfile.All.SRC (1 hunks)
Files skipped from review due to trivial changes (1)
  • .devcontainer/All/Dockerfile.All.SRC

@josesimoes josesimoes merged commit 590900c into nanoframework:main Aug 2, 2024
20 checks passed
This was referenced Nov 6, 2024
TerryFogg pushed a commit to TerryFogg/nf-interpreter that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev Container Build for ESP32 is broken
3 participants