Skip to content

Conversation

@AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Aug 3, 2024

Description

After the upgrade to IDF 5.2.2 the available managed heap reduced by 5K

Memory stats for C6

Before 5.2.2 (1.11.0.3)
Memory All () Managed:88572 Native total:303652/Free:108636/Largest:86016

After 5.2.2
Memory All () Managed:83124 Native total:298580/Free:110952/Largest:77824

Adjust the amount of memory reserved in IDF for Thread so as to increase memory reserved for Managed heap

Memory stats after change

Memory All () Managed:93168 Native total:298580/Free:100956/Largest:67584

Managed heap memory increased from 88572 to 93168
5K extra then what was on version 1.11.0.3 (pre 5.2.2)

Motivation and Context

Reported problem on discord

How Has This Been Tested?

  • Tested locally by running memory logging code.
  • Tested with Thread server sample

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies/declarations (update dependencies or assembly declarations and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Summary by CodeRabbit

  • Performance Improvements
    • Adjusted memory reservation for Thread functionality, potentially allowing more memory for other components.
  • Bug Fixes
    • Enhanced memory management strategies through optimized allocation settings.

@nfbot nfbot added the Type: bug label Aug 3, 2024
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 3, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The update to the _nanoCLR project for the ESP32 target involves a modification of memory reservation constants, specifically reducing the THREAD_EXTRA_IDF_MEMORY_RESERVE from 30 KB to 20 KB. This adjustment reflects a strategic decision to reallocate memory resources, potentially enhancing memory availability for other components while impacting memory management related to threading functionalities.

Changes

File Path Change Summary
targets/ESP32/_nanoCLR/Memory.cpp Reduced THREAD_EXTRA_IDF_MEMORY_RESERVE from 30 * 1024 to 20 * 1024.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6ca9f01 and 9c70088.

Files selected for processing (1)
  • targets/ESP32/_nanoCLR/Memory.cpp (1 hunks)
Additional comments not posted (1)
targets/ESP32/_nanoCLR/Memory.cpp (1)

33-33: Verify the impact of reducing THREAD_EXTRA_IDF_MEMORY_RESERVE.

The macro THREAD_EXTRA_IDF_MEMORY_RESERVE has been reduced from 30 * 1024 to 20 * 1024, reallocating 10 KB of memory. Ensure that this reduction does not adversely affect thread-related functionalities.

@AdrianSoundy AdrianSoundy merged commit a7c5102 into nanoframework:main Aug 3, 2024
@AdrianSoundy AdrianSoundy deleted the Adjust_C6_memory branch August 3, 2024 09:45
@josesimoes josesimoes added Platform: ESP32 Everything related specifically with ESP32 platform Series: ESP32C6 Series:ESP32H2 and removed Type: bug labels Aug 5, 2024
@coderabbitai coderabbitai bot mentioned this pull request Nov 10, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants