-
-
Notifications
You must be signed in to change notification settings - Fork 186
Update managed memory available for ESP32_C6 & H2 #3002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are limited to specific labels. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe update to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- targets/ESP32/_nanoCLR/Memory.cpp (1 hunks)
Additional comments not posted (1)
targets/ESP32/_nanoCLR/Memory.cpp (1)
33-33: Verify the impact of reducingTHREAD_EXTRA_IDF_MEMORY_RESERVE.The macro
THREAD_EXTRA_IDF_MEMORY_RESERVEhas been reduced from30 * 1024to20 * 1024, reallocating 10 KB of memory. Ensure that this reduction does not adversely affect thread-related functionalities.
Description
After the upgrade to IDF 5.2.2 the available managed heap reduced by 5K
Memory stats for C6
Before 5.2.2 (1.11.0.3)
Memory All () Managed:88572 Native total:303652/Free:108636/Largest:86016
After 5.2.2
Memory All () Managed:83124 Native total:298580/Free:110952/Largest:77824
Adjust the amount of memory reserved in IDF for Thread so as to increase memory reserved for Managed heap
Memory stats after change
Memory All () Managed:93168 Native total:298580/Free:100956/Largest:67584
Managed heap memory increased from 88572 to 93168
5K extra then what was on version 1.11.0.3 (pre 5.2.2)
Motivation and Context
Reported problem on discord
How Has This Been Tested?
Types of changes
Checklist
Summary by CodeRabbit