Update GCC version #3005
Update GCC version #3005
Conversation
13.3.Rel1
|
Caution Review failedThe pull request is closed. WalkthroughThe recent changes primarily involve upgrading the GNU Compiler Collection (GCC) version from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- .devcontainer/All/Dockerfile.All.SRC (1 hunks)
- .devcontainer/AzureRTOS/Dockerfile.AzureRTOS.SRC (1 hunks)
- .devcontainer/ChibiOS/Dockerfile.ChibiOS.SRC (1 hunks)
- .devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP.SRC (1 hunks)
- .devcontainer/TI/Dockerfile.TI.SRC (1 hunks)
- azure-pipelines-templates/download-install-arm-gcc-toolchain.yml (1 hunks)
- install-scripts/install-arm-gcc-toolchain.ps1 (1 hunks)
Files skipped from review due to trivial changes (2)
- .devcontainer/All/Dockerfile.All.SRC
- .devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP.SRC
Additional comments not posted (5)
azure-pipelines-templates/download-install-arm-gcc-toolchain.yml (1)
7-7: LGTM!The default value of
gccArmVersionhas been correctly updated to13.3.rel1..devcontainer/TI/Dockerfile.TI.SRC (1)
12-12: LGTM!The
GCC_VERSIONargument has been correctly updated to13.3.rel1..devcontainer/ChibiOS/Dockerfile.ChibiOS.SRC (1)
12-12: LGTM!The
GCC_VERSIONargument has been correctly updated to13.3.rel1..devcontainer/AzureRTOS/Dockerfile.AzureRTOS.SRC (1)
12-12: LGTM! Ensure the GCC URI is correct.The
GCC_VERSIONupdate from13.2.rel1to13.3.rel1is correct.Verify that the constructed
GCC_URIpoints to the correct resource.Verification successful
The GCC URI is correct.
The
GCC_VERSIONupdate from13.2.rel1to13.3.rel1is correct, and the constructed URI is accessible and valid.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the GCC URI. # Test: Check if the GCC URI is accessible. Expect: Successful HTTP response. curl -I https://armkeil.blob.core.windows.net/developer/Files/downloads/gnu/13.3.rel1/binrel/arm-gnu-toolchain-13.3.rel1-x86_64-arm-none-eabi.tar.xzLength of output: 1051
install-scripts/install-arm-gcc-toolchain.ps1 (1)
15-15: LGTM! Ensure the version update is correct.The default
$Versionupdate from "13.2.rel1" to "13.3.rel1" is correct.Verify that the new version is correctly handled by the script.
Verification successful
The version update is correctly handled.
The default
$Versionupdate from "13.2.rel1" to "13.3.rel1" is correctly implemented and consistently used throughout the script.
- The default value is set correctly.
- The
$Versionvariable is used appropriately in constructing URLs and paths.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the version update in the PowerShell script. # Test: Check if the new version is correctly handled by the script. Expect: No errors. pwsh -Command "if ([string]::IsNullOrEmpty(\$Version)) { \$Version = '13.3.rel1' } ; Write-Output \$Version"Length of output: 185
Script:
#!/bin/bash # Find all occurrences of the $Version variable in the install-arm-gcc-toolchain.ps1 script rg '\$Version' install-scripts/install-arm-gcc-toolchain.ps1 -A 3Length of output: 969
Script:
#!/bin/bash # Check the PowerShell script for any specific logic related to the $Version variable rg 'if|else|switch|case' install-scripts/install-arm-gcc-toolchain.ps1 -A 5Length of output: 4481
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- .devcontainer/All/Dockerfile.All (1 hunks)
- .devcontainer/AzureRTOS/Dockerfile.AzureRTOS (1 hunks)
- .devcontainer/ChibiOS/Dockerfile.ChibiOS (1 hunks)
- .devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP (1 hunks)
- .devcontainer/TI/Dockerfile.TI (1 hunks)
Files skipped from review due to trivial changes (4)
- .devcontainer/All/Dockerfile.All
- .devcontainer/AzureRTOS/Dockerfile.AzureRTOS
- .devcontainer/ChibiOS/Dockerfile.ChibiOS
- .devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP
Additional comments not posted (1)
.devcontainer/TI/Dockerfile.TI (1)
1-1: LGTM! Verify the existence of the new image version.The change updates the base image version from
v1.24tov1.25. Ensure that the new version exists and is compatible with your development environment.
***NO_CI***
Description
Update ARM GCC to 13.3.Rel1 for targets that use it.
See: https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads for more information.
Motivation and Context
Keeps compiler up-to-date.
How Has This Been Tested?
Screenshots
Types of changes
Checklist
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes