Skip to content

Proper handling thread creation failure #3063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Proper handling thread creation failure #3063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...zureRTOS/ST/_nanoCLR/System.Device.I2c/sys_dev_i2c_native_System_Device_I2c_I2cDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,11 @@ HRESULT Library_sys_dev_i2c_native_System_Device_I2c_I2cDevice::

if (status != TX_SUCCESS)
{
NANOCLR_SET_AND_LEAVE(CLR_E_PROCESS_EXCEPTION);
// failed to create the thread
// free stack memory
platform_free(palI2c->WorkingThreadStack);

NANOCLR_SET_AND_LEAVE(CLR_E_FAIL);
}

// bump custom state
Expand Down
6 changes: 5 additions & 1 deletion ...SiliconLabs/_nanoCLR/System.Device.I2c/sys_dev_i2c_native_System_Device_I2c_I2cDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,11 @@ HRESULT Library_sys_dev_i2c_native_System_Device_I2c_I2cDevice::

if (status != TX_SUCCESS)
{
NANOCLR_SET_AND_LEAVE(CLR_E_PROCESS_EXCEPTION);
// failed to create the thread
// free stack memory
platform_free(palI2c->WorkingThreadStack);

NANOCLR_SET_AND_LEAVE(CLR_E_FAIL);
}

// bump custom state
Expand Down
6 changes: 5 additions & 1 deletion .../nanoFramework.Device.OneWire/nf_dev_onewire_nanoFramework_Device_OneWire_OneWireHost.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,11 @@ HRESULT FindOneDevice(CLR_RT_StackFrame &stack, bool findFirst)

if (status != TX_SUCCESS)
{
NANOCLR_SET_AND_LEAVE(CLR_E_PROCESS_EXCEPTION);
// failed to create the thread
// free stack memory
platform_free(workingThreadStack);

NANOCLR_SET_AND_LEAVE(CLR_E_FAIL);
}

// bump custom state
Expand Down