Remove deprecated Windows.Storage API #3090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughThe pull request removes support for the Windows.Storage API and all related components. Numerous Windows.Storage options, files, and native method stubs have been deleted. Build scripts, Visual Studio project files, and solution configurations have been updated to remove Windows.Storage references and conditionals. Header inclusions have been modified to rely solely on System.IO.FileSystem. Additionally, SD card support logic has been simplified by commenting out or disabling threading and target-specific SD card features, and several target configuration files now use updated header guards. Migration work for FATFS integration has also been introduced. Changes
Sequence Diagram(s)sequenceDiagram
participant BuildSystem
participant CMakeConfig
participant RTOS_Logic
BuildSystem->>CMakeConfig: Parse build configuration
CMakeConfig-->>BuildSystem: (Old Flow) Check RTOS type → include Windows.Storage API if FreeRTOS
BuildSystem->>RTOS_Logic: Setup SD Card support
RTOS_Logic-->>BuildSystem: Invoke Windows.Storage-specific code
Note over BuildSystem,RTOS_Logic: Old conditional flow
BuildSystem->>CMakeConfig: (New Flow) Remove Windows.Storage option
CMakeConfig-->>BuildSystem: Always include System.IO.FileSystem API
BuildSystem->>RTOS_Logic: Setup SD Card support without Windows.Storage thread/task
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
networkfusion
changed the title
Member
Author
|
@josesimoes , potentially another CI issue here... |
- Adjust headers. - Rename and migrate targets config files. - Remove target win.storage common headers. - Remove assembly from virtual device interop assemblies table.
Member
|
@networkfusion for some reason AZDO didn't pick up this PR... 🤷🏻♂️ Anyway, I've completed the migration and move the remaining Win.Storage config options still in the various targets/platforms. |
Member
Author
I can only thing the reason for AZDO throwing a wobbly was that it started as a draft PR... |
(it does not support System.IO.FileSystem)
networkfusion
force-pushed
the
remove-windows-storage
branch
from
f4f1934 to
24c6554
Compare
josesimoes
force-pushed
the
remove-windows-storage
branch
from
24c6554 to
2587b44
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CMake/Modules/FindSystem.IO.FileSystem.cmake (2)
11-11: Document the NXP-specific FatFs path.While the change aligns with the migration from Windows.Storage to System.IO.FileSystem, consider adding a comment explaining why this specific NXP FatFs implementation path is used.
+ # Use NXP-specific FatFs implementation as it's the last platform using Windows.Storage set(FATFS_PLATFORM ${PROJECT_SOURCE_DIR}/targets/FreeRTOS/NXP/_FatFs)
11-11: Consider making the FatFs platform path more configurable.The hardcoded NXP-specific path might limit reusability for other platforms. Consider making it configurable through a CMake option.
+ # Allow overriding the FatFs platform path through CMake option + if(DEFINED NF_FATFS_PLATFORM_PATH) + set(FATFS_PLATFORM ${NF_FATFS_PLATFORM_PATH}) + else() set(FATFS_PLATFORM ${PROJECT_SOURCE_DIR}/targets/FreeRTOS/NXP/_FatFs) + endif()Also applies to: 79-79
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
CMake/Modules/FindSystem.IO.FileSystem.cmake(2 hunks)targets/FreeRTOS/NXP/NXP_MIMXRT1060_EVK/CMakePresets.json(1 hunks)targets/FreeRTOS/NXP/NXP_MIMXRT1060_EVK/nanoCLR/main.c(2 hunks)targets/FreeRTOS/NXP/_FatFs/fatfs_FS_Driver.cpp(1 hunks)targets/FreeRTOS/NXP/_FatFs/fatfs_FS_Driver.h(1 hunks)targets/netcore/nanoCLR.sln(0 hunks)targets/win32/nanoCLR.sln(0 hunks)
💤 Files with no reviewable changes (2)
- targets/netcore/nanoCLR.sln
- targets/win32/nanoCLR.sln
✅ Files skipped from review due to trivial changes (2)
- targets/FreeRTOS/NXP/_FatFs/fatfs_FS_Driver.h
- targets/FreeRTOS/NXP/_FatFs/fatfs_FS_Driver.cpp
🚧 Files skipped from review as they are similar to previous changes (2)
- targets/FreeRTOS/NXP/NXP_MIMXRT1060_EVK/CMakePresets.json
- targets/FreeRTOS/NXP/NXP_MIMXRT1060_EVK/nanoCLR/main.c
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: nf-interpreter (Check_Code_Style)
- GitHub Check: nf-interpreter (Nightly build) (Build_STM32_targets ST_NUCLEO64_F091RC)
- GitHub Check: nf-interpreter (Nightly build) (Build_STM32_targets ORGPAL_PALX)
- GitHub Check: nf-interpreter (Nightly build) (Build_STM32_targets ORGPAL_PALTHREE)
- GitHub Check: nf-interpreter (Nightly build) (Check_Build_Options)
- GitHub Check: nf-interpreter (Check_Build_Options)
josesimoes
pushed a commit
that referenced
this pull request
Mar 17, 2025
(cherry picked from commit 3aa6ab7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist
Summary by CodeRabbit