Update mscorlib declaration

[josesimoes]

Description

• Update mscorlib declaration.

Motivation and Context

• Following:
  • Remove types to exclude from project file CoreLibrary#234
  • Rework ArgumentNullException CoreLibrary#235

How Has This Been Tested?

• Tested against Bump version and assembly version CoreLibrary#236

Screenshots

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue with code or algorithm)
• New feature (non-breaking change which adds functionality to code)
• Breaking change (fix or feature that would cause existing functionality to change)
• Config and build (change in the configuration and build system, has no impact on code or features)
• Dev Containers (changes related with Dev Containers, has no impact on code or features)
• Dependencies/declarations (update dependencies or assembly declarations and changes associated, has no impact on code or features)
• Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

• My code follows the code style of this project (only if there are changes in source code).
• My changes require an update to the documentation (there are changes that require the docs website to be updated).
• I have updated the documentation accordingly (the changes require an update on the docs in this repo).
• I have read the CONTRIBUTING document.
• I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Summary by CodeRabbit

• Chores

  • Optimized runtime versioning and method resolution to improve stability and performance.

• Refactor

  • Revised internal exception handling, date/time, and nullable type structures for enhanced consistency and robustness.

[coderabbitai]

Walkthrough

The changes update native library components for mscorlib. In the C++ file, five NULL entries are removed from the method_lookup array and assembly identifiers and version information in g_CLR_AssemblyNative_mscorlib are updated. In the header file, several new static fields are added to exception and date/time related structures, some existing static fields are updated, obsolete structures are removed, and one structure is renamed with a corresponding field update. These modifications refine method lookup handling and extend the metadata for native types.

Changes

File(s)	Change Summary
src/…/corlib_native.cpp	Removed five NULL entries from the method_lookup array; updated assembly identifiers (switching from 0x6386D1B4 → 0x9F295833 for NANOCLR_REFLECTION == TRUE and from 0xA145623D → 0xFDC67F52 for FALSE); incremented version info from { 100, 5, 0, 22 } to { 100, 5, 0, 23 }.
src/…/corlib_native.h	Added new static fields in Library_corlib_native_System_ArgumentException and introduced Library_corlib_native_System_ArgumentNullException; updated static fields in System_TimeSpan, System_DateTime, System_EventArgs, and System_Threading_Timeout; removed obsolete structures (EditorBrowsableState and DebuggerBrowsableAttribute); renamed AccessedThroughPropertyAttribute to NullableAttribute (with a field name change) and added NullableContextAttribute.

Possibly related PRs

• Rework DateTime and TimeSpan #3084: Addresses modifications to the g_CLR_AssemblyNative_mscorlib structure and the method_lookup array, directly related to the changes in the C++ file.
• Update declaration of mscorlib #3122: Involves updates to the method lookup mechanism and assembly identification, aligning with the current modifications.
• Update mscorlib assembly declarations #3070: Focuses on assembly versioning and method lookup updates in corlib_native.cpp, closely mirroring several changes presented in this PR.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8f3eb00 and 3b85a31.

📒 Files selected for processing (2)

• src/CLR/CorLib/corlib_native.cpp (1 hunks)
• src/CLR/CorLib/corlib_native.h (6 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: nf-interpreter (Check_Code_Style)
• GitHub Check: nf-interpreter (Nightly build) (Build_STM32_targets ST_NUCLEO64_F091RC)
• GitHub Check: nf-interpreter (Nightly build) (Build_STM32_targets ORGPAL_PALX)
• GitHub Check: nf-interpreter (Nightly build) (Build_STM32_targets ORGPAL_PALTHREE)
• GitHub Check: nf-interpreter (Nightly build) (Check_Build_Options)
• GitHub Check: nf-interpreter (Check_Build_Options)

🔇 Additional comments (11)

src/CLR/CorLib/corlib_native.cpp (3)

1500-1500: Assembly identifier updated for NANOCLR_REFLECTION=TRUE.

The assembly identifier for mscorlib has been changed from the previous value to 0x9F295833.

---

1504-1504: Assembly identifier updated for NANOCLR_REFLECTION=FALSE.

The assembly identifier for mscorlib has been changed from the previous value to 0xFDC67F52.

---

1511-1511: Version number incremented in mscorlib declaration.

The version number has been updated from 100.5.0.22 to 100.5.0.23, which aligns with the PR's objective to update the mscorlib declaration.

src/CLR/CorLib/corlib_native.h (8)

325-327: Added new static fields to ArgumentException.

These new static fields provide string references for common argument exception messages, which will help standardize error handling.

---

334-339: Added new ArgumentNullException structure.

This new structure provides a dedicated field for generic null argument error messages, improving error handling specificity.

---

455-457: Updated TimeSpan static field values.

The static field values for TimeSpan have been updated to ensure unique identifiers across the library.

---

487-489: Updated DateTime static field values.

The static field values for DateTime have been updated to maintain consistent unique identifiers.

---

591-591: Updated EventArgs.Empty static field value.

The static field value has been updated from 9 to 13 to avoid conflicts with other static fields.

---

798-803: Renamed structure to NullableAttribute.

The structure previously named AccessedThroughPropertyAttribute has been renamed to NullableAttribute with an updated field name to better reflect its purpose.

---

805-810: Added NullableContextAttribute structure.

This new structure supports C# nullable reference type features in the .NET nanoFramework.

---

975-975: Updated Timeout.InfiniteTimeSpan static field value.

The static field value has been updated from 11 to 15 to maintain unique static field identifiers.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.