Work on Debugging_Deployment_Status #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- extract command and related code from compiler define NANOCLR_ENABLE_SOURCELEVELDEBUGGING (doesn't make sense to be related, we need to get deployment status regardless of debugging at source level) - remove BlockStorageDevice_MaxSectorWrite_uSec and BlockStorageDevice_MaxBlockErase_uSec (these can be ditched, the 'worst' case application for these was the removable storage which nanoFramework is not handling in the HAL/PAL anymore) - remove 'extended' fields from Debugging_Deployment_Status.Reply (we are not supporting incremental deployment at this time - Signed-off-by: José Simões <jose.simoes@eclo.solutions>
josesimoes
added
Area: Interpreter
|
Hi @josesimoes, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: José Simões jose.simoes@eclo.solutions