Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error code to reply of access memory commands #361

Merged

Conversation

josesimoes
Copy link
Member

  • need this to get details when an access memory fails (a simple bool is not descriptive enough and doesn't help much)
  • add reply with error code to WriteMemory and EraseMemory

Signed-off-by: José Simões jose.simoes@eclo.solutions

- need this to get details when an access memory fails (a simple bool is not descriptive enough and doesn't help much)
- add reply with error code to WriteMemory and EraseMemory

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Area: Interpreter Everything related with the interpreter, execution engine and such Type: enhancement labels Jun 23, 2017
@nfbot
Copy link
Member

nfbot commented Jun 23, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 2137374 into nanoframework:master Jun 23, 2017
@josesimoes josesimoes deleted the add-error-codes-to-access-memory-cmds branch June 23, 2017 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants