-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clr managed heap document improvements #369
clr managed heap document improvements #369
Conversation
Hi @networkfusion, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
docs/ChibiOS HAL/clr-managed-heap.md
Outdated
- the target linker file provided for nanoCLR at the target board folder, e.g. [STM32F091xC.ld](../../targets/CMSIS-OS/ChibiOS/ST_NUCLEO_F091RC/nanoCLR/STM32F091xC.ld) | ||
For STM32 based devices: | ||
The configurations are spread between two linker files: | ||
- [rules.ld](../../targets/CMSIS-OS/ChibiOS/common/rules.ld) (which is common to all STM32 based ChibiOS targets **except** the F7 series that use [rules_STM32F7xx.ld](../../targets/CMSIS-OS/ChibiOS/common/rules_STM32F7xx.ld) instead) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I don't think this is true any more, the F7 actually defines the differences within its own ld.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that you are correct. Care to update the bit above so this can be merged? 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who ever made the change, should check it's spellchecker. It has some bugs, line 26 and 32 have some new words I didn't know before or and most likely the words exaple (line 26) and manged (line 32) are waiting to be corrected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@piwi1263 done (I didn't have a spell checker installed, I have now :-p) typing too quickly for my own good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the typos pointed by @piwi1263 and make the changes related with F7.
No description provided.