I2c #445
I2c #445
Conversation
|
Hi @MikroBusNet, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
| @@ -40,6 +40,14 @@ int main(void) { | |||
| // HAL initialization, this also initializes the configured device drivers | |||
| // and performs the board-specific initializations. | |||
| halInit(); | |||
|
|
|||
| // check for valid CLR image | |||
There was a problem hiding this comment.
I believe that this is here in error... this code block is already bellow, executing only if the user button is NOT pressed.
There was a problem hiding this comment.
Whoops !
This code is indeed here on purpose so that I do not have to press the button to leave booter mode.
This was supposed to be private code.
Edit: btw, I should not have pushed this file either.
There was a problem hiding this comment.
hum... you say you have to push the button to exit nanoBooter?! that's supposed to be the oposite!
Press it to REMAIN on booter.
I've been using the master code on this same board without any issues on this behaviour... please double check.
There was a problem hiding this comment.
Anyways, if you don't have any changes just remove this file from the PR.
| @@ -67,7 +67,7 @@ | |||
| * @brief Enables the I2C subsystem. | |||
| */ | |||
| #if !defined(HAL_USE_I2C) || defined(__DOXYGEN__) | |||
| #define HAL_USE_I2C FALSE | |||
| #define HAL_USE_I2C TRUE | |||
There was a problem hiding this comment.
The definition for HAL_USE_I2C has to depend on the CMake option API_Windows.Devices.I2c and it's already performed in the general CMake (line 262).
-
Please comment this block (and the equivalents on the others targets) adding a comment
// this option is set at target_platform.h (from config file) -
Please update target_platform.h.in and add the corresponding option to handle the HAL_USE_I2C
|
@MikroBusNet please pull + rebase the changes from the master into your branch. |
This is the first try on Devices.I2c Signed-off-by: Christophe Gerbier <christophe@mikrobusnet.org>
Error codes and number of bytes read/written are not implemented yet. If an errors occurs, then it will return "UnknownError". Signed-off-by: Christophe Gerbier <christophe@mikrobusnet.org>
Related to José's comment on the PR. Signed-off-by: Christophe Gerbier <christophe@mikrobusnet.org>
Signed-off-by: Christophe Gerbier <christophe@mikrobusnet.org>
No description provided.