Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dereference Unsigned shorts in SPI #484

Merged
merged 2 commits into from Sep 5, 2017
Merged

Dereference Unsigned shorts in SPI #484

merged 2 commits into from Sep 5, 2017

Conversation

ghost
Copy link

@ghost ghost commented Sep 4, 2017

Signed-off-by: Christophe Gerbier christophe@mikrobusnet.org

Description

Removed the Marshal() methods in 16bit transfers to use the same way of dereference as in 8bit transfer.

Motivation and Context

Having the same kind of code in both 8 and 16 bit transfer methods.

How Has This Been Tested? (if applicable)

Tested on Quail, STM32F429.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Removed the Marshal() methods in 16bit transfers to use the same way of dereference as in 8bit transfer.

Signed-off-by: Christophe Gerbier <christophe@mikrobusnet.org>
@nfbot
Copy link
Member

nfbot commented Sep 4, 2017

Hi @MikroBusNet,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets labels Sep 5, 2017
@josesimoes josesimoes merged commit 9a032cf into nanoframework:master Sep 5, 2017
@ghost ghost deleted the SPI_Deref16 branch September 5, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants