Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ChibiOS rules #489

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Fix ChibiOS rules #489

merged 1 commit into from
Sep 5, 2017

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Sep 5, 2017 •
edited
Loading

Description

  • correct declaration of several regions on linker file which had their names and alignment incorrect
  • add missing empty lines at end of files

Motivation and Context

How Has This Been Tested? (if applicable)

  • flashed empty target board and verified correct boot and USB device enumeration on nanoBooter and nanoCLR
  • also checked output on SWO viewer

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Fix ChibiOS rules
4f1ea8d 
- correct declaration of several regions on linker file which had their names and alignemt incorrect
- fixes #221
- add missing empty lines at end of files

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added the Series: STM32xx Everything related specifically with STM32 targets label Sep 5, 2017
@nfbot
Copy link
Member

nfbot commented Sep 5, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 30fea59 into nanoframework:master Sep 5, 2017
@josesimoes josesimoes deleted the fix-221 branch September 5, 2017 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot