Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes exception in ToString() #490

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Conversation

josesimoes
Copy link
Member

Description

Implements hal_snprintf for ChibiOS nanoCRT allowing printf .

Motivation and Context

How Has This Been Tested? (if applicable)

  • C# test app with a call to Int32.ToString() and Int32.ToString("N0") without throwing any exception.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- fix nanoframework/Home#215
- fix nanoframework/Home#118

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added the Series: STM32xx Everything related specifically with STM32 targets label Sep 5, 2017
@nfbot
Copy link
Member

nfbot commented Sep 5, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 51ba297 into nanoframework:master Sep 5, 2017
@josesimoes josesimoes deleted the fix-118 branch September 5, 2017 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants