Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definitive fix for I2C and SPI on F7 MCU #495

Merged
merged 2 commits into from Sep 10, 2017
Merged

Definitive fix for I2C and SPI on F7 MCU #495

merged 2 commits into from Sep 10, 2017

Conversation

ghost
Copy link

@ghost ghost commented Sep 10, 2017

Description

This fixes the "garbage" issue on F7 MCUs with I2C and SPI.

How Has This Been Tested?

Tested on Nucleo-F746ZG with Devantech LCD03 (I2C @100khz) and MikroElektronika Led8x8 board (SPI)

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Christophe Gerbier added 2 commits September 10, 2017 09:29
Work on I2C for STM32F7xx
19de023 
Added code to handle STM32F7xx MCU.

Signed-off-by: Christophe Gerbier <christophe@mikrobusnet.org>
Definitive fix for I2C and SPI on STM32F7xx
f96a8d9 
No more garbage.

Signed-off-by: Christophe Gerbier <christophe@mikrobusnet.org>
@nfbot
Copy link
Member

nfbot commented Sep 10, 2017

Hi @MikroBusNet,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

This was referenced Sep 10, 2017
Closed
Closed
josesimoes
josesimoes approved these changes Sep 10, 2017
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant!! 👏

@josesimoes josesimoes merged commit 9ae0943 into nanoframework:master Sep 10, 2017
@ghost ghost deleted the i2c_F7 branch September 10, 2017 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nfbot @josesimoes