Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct include version for I2C #497

Merged
merged 1 commit into from
Sep 13, 2017
Merged

Correct include version for I2C #497

merged 1 commit into from
Sep 13, 2017

Conversation

piwi1263
Copy link
Member

Description

During configuring the reference board ST_STM32F4_DISCOVERY an incorrect version is included during copy of source members. The I2C include is made for V2 but must be for V1.

Motivation and Context

How Has This Been Tested?

By recompiling, after the change of course. The compile didn't break anymore.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: piwi1263 piwi1263@gmail.com

The I2C include is made for V2 but must be for V1.
The in the issue mentioned board was not included in the copy select for version 1.
Fixes issue 225.

Signed-off-by: piwi1263 <piwi1263@gmail.com>
@nfbot
Copy link
Member

nfbot commented Sep 12, 2017

Hi @piwi1263,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added the Series: STM32xx Everything related specifically with STM32 targets label Sep 13, 2017
@josesimoes josesimoes merged commit 3ff480c into nanoframework:master Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants