Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix I2C for F769I reference board #500

Merged
merged 1 commit into from
Sep 13, 2017
Merged

Fix I2C for F769I reference board #500

merged 1 commit into from
Sep 13, 2017

Conversation

piwi1263
Copy link
Member

Description

Localize board.h in target folder for the above board
Localize board.c in target folder for the above board
Change the board.h to accomodate for I2C1 on Arduino header pins D14, D15
Change the mcuconf.h file to activate the I2C channel so compiler doesn't break

Since the compiler still breaks in the SPI Channels missing, the SPI1 channel has been activated in mcuconf.h too.

Motivation and Context

  • I2C wasn't configured in the ChibiOS based files, so had to local copy them to the target boards to be able to change pin definitions for B8, B9.

How Has This Been Tested?

Compile the firmware images, flashed them to an F769I-DISCOVERY board and deployed a I2C demo app to check it's I2C1 working.

Screenshots

N/A.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: piwi1263 piwi1263@gmail.com

Localize board.h in target folder for the above board
Localize board.c in target folder for the above board
Change the board.h to accomodate for I2C1 on Arduino header pins D14, D15
Change the mcuconf.h file to activate the SPI and I2c channels so compiler doesn't break

Signed-off-by: piwi1263 <piwi1263@gmail.com>
@nfbot
Copy link
Member

nfbot commented Sep 13, 2017

Hi @piwi1263,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@piwi1263 piwi1263 requested a review from a user September 13, 2017 21:29
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about PIN_OSPEED_LOW setting for I2C ?

@josesimoes josesimoes added the Series: STM32xx Everything related specifically with STM32 targets label Sep 13, 2017
@josesimoes josesimoes merged commit 56fcbf7 into nanoframework:master Sep 13, 2017
@piwi1263
Copy link
Member Author

About those low speed setting, they are the same as on the STM32F746ZG board, since these are working properly I've used those settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants