Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed I2C transmit timeout #507

Merged
merged 1 commit into from
Sep 16, 2017
Merged

Changed I2C transmit timeout #507

merged 1 commit into from
Sep 16, 2017

Conversation

ghost
Copy link

@ghost ghost commented Sep 15, 2017

Description

Changed timeout value from TIME_INFINITE to 2 seconds.

This will prevent the board from hanging in case of transmission error. The function will return the I2cTransferStatus_UnknownError code.

How Has This Been Tested?

Tested with no I2C device connected.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

From TIME_INFINITE to 2 seconds.
This will prevent the board from hanging in case of transmission error. The function will return the _I2cTransferStatus_UnknownError_ code.
@nfbot
Copy link
Member

nfbot commented Sep 15, 2017

Hi @MikroBusNet,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 99ad98a into master Sep 16, 2017
@josesimoes josesimoes deleted the I2C-Timeout branch September 16, 2017 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants