Update targetHAL_Time.cpp #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes nanoframework/Home#257. Now, with a time set internally to 12/17/2017 08:00:00, `Console.WriteLine("utcNow : " + DateTime.UtcNow.ToString());` is returning `utcNow : 12/17/2017 08:00:39` (The 39 seconds are due to the manual startup time of the debug session after the board's reset)
|
Hi @MikroBusNet, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
piwi1263
approved these changes
Dec 17, 2017
josesimoes
reviewed
Dec 20, 2017
| @@ -36,7 +36,7 @@ signed __int64 HAL_Time_CurrentDateTime(bool datePartOnly) | |||
|
|
|||
| st.wDay = (unsigned short) _dateTime.day; | |||
| st.wMonth = (unsigned short) _dateTime.month; | |||
| st.wYear = (unsigned short) _dateTime.year; | |||
| st.wYear = (unsigned short) (_dateTime.year + 1980); // ChibiOS is counting years since 1980 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes incorrect handling of internal system time.
Motivation and Context
How Has This Been Tested?
With a time set internally to 12/17/2017 08:00:00,
Console.WriteLine("utcNow : " + DateTime.UtcNow.ToString());is returning
utcNow : 12/17/2017 08:00:39The 39 seconds are due to the manual startup time of the debug session after the board's reset.