Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update corlib_native_System_Number.cpp #549

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Update corlib_native_System_Number.cpp #549

merged 1 commit into from
Dec 20, 2017

Conversation

ghost
Copy link

@ghost ghost commented Dec 18, 2017

Description

Fixes nanoframework/Home#260

How Has This Been Tested?

var i64 = Convert.ToInt64("01010101", 2);
long i64a = 1234567;
ulong i64b = 200;
Console.WriteLine("i64 = " + i64.ToString());
Console.WriteLine("i64a = " + i64a.ToString());
Console.WriteLine("i64a = " + i64a.ToString("X"));
Console.WriteLine("i64b = " + i64b.ToString("X"));

now returns

i64 = 85
i64a = 1234567
i64a = 12D687
i64b = C8

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Dec 18, 2017

Hi @MikroBusNet,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 43886ec into develop Dec 20, 2017
@josesimoes josesimoes deleted the MBN-Int64 branch December 20, 2017 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Int64.ToString() returns wrong value
2 participants