Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update corlib_native_System_Number.cpp #550

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Conversation

ghost
Copy link

@ghost ghost commented Dec 20, 2017

Description

Make ouput conform to .Net Desktop regarding formatting of integers and precision.

Motivation and Context

Output from .ToString(format) was not compliant with .Net desktop.

How Has This Been Tested?

private static uint myVar = 2;
private static uint myVar0 = 0;

Console.WriteLine("myVar0 = " + myVar0.ToString("N0"));
Console.WriteLine("myVar0 = " + myVar0.ToString("N1"));
Console.WriteLine("myVar0 = " + myVar0.ToString("N2"));

Console.WriteLine("myVar = " + myVar.ToString("N0"));
Console.WriteLine("myVar = " + myVar.ToString("N1"));
Console.WriteLine("myVar = " + myVar.ToString("N2"));
Console.WriteLine("myVar = " + myVar.ToString("N3"));
Console.WriteLine("myVar = " + myVar.ToString("N4"));
Console.WriteLine("myVar = " + myVar.ToString("D4"));

nanoFramework now returns :

myVar0 = 0
myVar0 = 0.0
myVar0 = 0.00
myVar = 2
myVar = 2.0
myVar = 2.00
myVar = 2.000
myVar = 2.0000
myVar = 0002

.Net Desktop returns :

myVar0 = 0
myVar0 = 0,0
myVar0 = 0,00
myVar = 2
myVar = 2,0
myVar = 2,00
myVar = 2,000
myVar = 2,0000
myVar = 0002

The only difference is the CultureInfo that is US in nanoFramework.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Make ouput conform to .Net Desktop regarding formatting of integers and precision.
@nfbot
Copy link
Member

nfbot commented Dec 20, 2017

Hi @MikroBusNet,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 646fb61 into develop Dec 21, 2017
@josesimoes josesimoes deleted the MBN-NumbersNET branch December 21, 2017 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants