FatFS Integration #551
FatFS Integration #551
Conversation
|
Hi @networkfusion, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
josesimoes
added
Series: STM32xx
| @@ -129,7 +129,7 @@ | |||
| * @brief Enables the SDC subsystem. | |||
| */ | |||
| #if !defined(HAL_USE_SDC) || defined(__DOXYGEN__) | |||
| #define HAL_USE_SDC FALSE | |||
| #define HAL_USE_SDC TRUE | |||
There was a problem hiding this comment.
This define here should be moved to target_board.h like all the others that we are touching and making dependent of a cmake option. See line 34 above, for example, with the ADC submodule.
There was a problem hiding this comment.
This is where I am having trouble because FatFS can be used for both SD and USB (and possibly flash, but lets not go there) so I am trying to work out the best way of setting the options as some people may not want either SD or USB enabled... Should the file system turn these things on regardless???
There was a problem hiding this comment.
anyway, I guess that is not too important right now... and will only need minor refactoring with the changes so I have changed as suggested (although it is target_platform.h not target_board.h)...
removed generated by automated tool header from file as it is not... deleted unnecessary file.
| @@ -3,11 +3,6 @@ | |||
| // See LICENSE file in the project root for full license information. | |||
| // | |||
|
|
|||
| ////////////////////////////////////////////////////////////////////////////// | |||
There was a problem hiding this comment.
This comment block is really meant to be here. 😃
It will be in the generated output file: target_platform.h as a warning to someone browsing on the build folder and that could think that changing this file will have any lasting effect on the build.
Provides the base for integrating file system support for nanoFramework leveraging the FatFS library.
Description
Adds the option for FatFs to be built by extracting the FatFs sources and adding them as part of the build.
Motivation and Context
It is necessary for full filesystem support, especially handy when used with an SD card (not sure if enabling the SD should be tied to FS or a separate option that is dependent on it... TBD.
How Has This Been Tested?
Build without error so far. Further testing should be carried out before merging.
Types of changes
Checklist: