Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update target_windows_devices_serialcommunication_config.cpp #571

Merged
5 commits merged into from
Jan 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 13, 2018

Description

Add UART configuration for the four sockets.

Motivation and Context

Quail board is using 4 UART, one on each socket.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Add UART configuration for the four sockets.
@nfbot
Copy link
Member

nfbot commented Jan 13, 2018

Hi @MikroBusNet,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what is missing.

The idea is that you add a "block" for each UART. Starting at the header and with all the configs bellow.
This way when you want to remove an UART you just delete that block, you don't go have to chase each individual line in the rest of the code.

@ghost ghost merged commit a7e7122 into develop Jan 13, 2018
@ghost ghost deleted the MBN-Quail_UART branch January 14, 2018 11:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants