Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Wire Protocol comm issues #596

Merged
merged 2 commits into from
Feb 4, 2018
Merged

Fix Wire Protocol comm issues #596

merged 2 commits into from
Feb 4, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Remove unnecessary semaphore
  • Remove buffering from USB over serial

Motivation and Context

  • Fixes issues with unstable WP
  • The USB connection was having issues because of ZLP not being sent for USB CDC
    (see here)

How Has This Been Tested?

  • Using WPF test app in debugger repo. The VS hang could be reproduced with:
  1. Connect to the board
  2. Perform a number of commands
  3. Send Reboot CLR command
  4. Can send more commands
  5. Send Reboot CLR again and the board hangs with an hard exception related with task switching in all STM32 boards using ChibiOS.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Fix Wire Protocol comm issues
ab818ad 
- Remove unnecessary sempahore
- Remove buffering from USB over serial (was causing issues with ZLP not being sent for USB CDC hosts)

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets labels Feb 4, 2018
@nfbot
Copy link
Member

nfbot commented Feb 4, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

josesimoes added a commit to nanoframework/nf-Community-Targets that referenced this pull request Feb 4, 2018
@josesimoes
Fix WP comm issues
da77bc1 
- See nanoframework/nf-interpreter#596

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
This was referenced Feb 4, 2018
Merged
Merged
@josesimoes josesimoes merged commit 37152fa into nanoframework:develop Feb 4, 2018
@josesimoes josesimoes deleted the fix-wp-comm branch February 4, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot