Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on Gpio #603

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Work on Gpio #603

merged 1 commit into from
Feb 9, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Extract ext driver var from main to targetPAL
  • Add GPIO_Initialize and GPIO_Uninitialize functions
  • Add nanoPAL_GPIO header

Motivation and Context

How Has This Been Tested?

  • Gpio+Events app form samples repo. Multiple deployments and debug session didn't show exception on event handler setting as before.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Work on Gpio
f96e39c 
- Extract ext driver var from main to targetPAL
- Add GPIO_Initialize and GPIO_Uninitialize functions
- Add nanoPAL_GPIO header

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: enhancement Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets labels Feb 9, 2018
@nfbot
Copy link
Member

nfbot commented Feb 9, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Copy link
Member Author

@AdrianSoundy I did look into the ESP32 code to implement these changes there, but couldn't find it...
Basically functions to init and uninit everything related with Gpio on CLR boot and shutdown were added.
For ChibiOS it envolved reinit the EXT (driver that manages the hardware interrupts) var.
Please confirm if any of this needs to be implemented in ESP32.

josesimoes added a commit to Eclo/nf-Community-Targets that referenced this pull request Feb 9, 2018
@josesimoes
Merge changes with EXT driver
f763749 
- Ported from nanoframework/nf-interpreter#603

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
josesimoes added a commit to Eclo/nf-Community-Targets that referenced this pull request Feb 9, 2018
@josesimoes
Merge changes with EXT driver
26ce2e0 
- Ported from nanoframework/nf-interpreter#603
#ALL#

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes merged commit ee97e61 into nanoframework:develop Feb 9, 2018
@josesimoes josesimoes deleted the fix-282 branch February 9, 2018 14:10
@josesimoes josesimoes mentioned this pull request Feb 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gpio events do not behave as expected
2 participants
@josesimoes @nfbot