Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noreturn attribute to thread function #606

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Add noreturn GCC attribute to thread functions

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- Fixes nanoframework/Home#140

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets labels Feb 9, 2018
@nfbot
Copy link
Member

nfbot commented Feb 9, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Copy link
Member Author

@AdrianSoundy being this attribute a GCC thing this improvement should be valid for ESP32 code too... Please verify if everything works there after adding that.

@josesimoes josesimoes merged commit bfee351 into nanoframework:develop Feb 9, 2018
@josesimoes josesimoes deleted the fix-140 branch February 9, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve RAM usage on ChibiOS by changing thread declarations
2 participants