Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on native events #608

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Work on native events #608

merged 2 commits into from
Feb 12, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Rework events to add missing code for handling HAL completions and thread idle
  • Remove NANOCLR_RELINQUISHEXECUTIONCONTROL (not required anymore)
  • Add System State variable and set/reset/query functions
  • Add macros to wrap native interrupt handlers
  • Move types and enums from C++ HAL to C HAL header
  • Add CPU_Sleep native
  • Clean up unused code

Motivation and Context

  • Fixes/improves engine events handling

How Has This Been Tested?

  • Several apps from samples repo.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes josesimoes added Type: enhancement Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets labels Feb 12, 2018
@nfbot
Copy link
Member

nfbot commented Feb 12, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Work on native events
b72f70f 
- Rework events to add missing code for handling HAL completions and thread idle
- Remove NANOCLR_RELINQUISHEXECUTIONCONTROL (not required anymore)
- Add System State variable and set/reset/query functions
- Add macros to wrap native interrupt handlers
- Move types and enums from C++ HAL to C HAL header
- Add CPU_Sleep native
- Clean up unused code

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes force-pushed the work-native-events branch 2 times, most recently from b5f6316 to af4e5c9 Compare February 12, 2018 18:10
@josesimoes
Copy link
Member Author

@AdrianSoundy please check if I didn't miss any event handler when adding the NATIVE_INTERRUPT_START and NATIVE_INTERRUPT_END wrappers (I believe I couldn't find them all, GPIO for example wasn't in the cpp file, don't know if it lives elsewhere)

@josesimoes josesimoes merged commit 4bab575 into nanoframework:develop Feb 12, 2018
@josesimoes josesimoes deleted the work-native-events branch February 12, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot