Fix issues that stopped ESP32 build after change to events #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commented out CPU_Sleep from nanoHALV2.h for now as compile giving error that uint64_t is not defined. Can't find out why for moment. But doesn't seem to need it as also defined in TargetHal_power.h. Both arm and esp32 build ok without it.
|
Hi @AdrianSoundy, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
josesimoes
approved these changes
Feb 13, 2018
|
It's curious that the Appveyor build didn't complain about these... Needs further investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commented out CPU_Sleep from nanoHALV2.h for now as compile giving error that uint64_t is not defined. Can't find out why for moment. But doesn't seem to need it as also defined in TargetHal_power.h. Both arm and esp32 builds ok without it.
Types of changes
Checklist:
Signed-off-by: adriansoundyadriansoundy@gmail.com