Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRC32 in Wire Protocol is now optional #629

Merged
merged 2 commits into from
Feb 28, 2018

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Feb 28, 2018

Description

  • Add CMake option to optionally support CRC32 in Wire Protocol
  • Update CMakes accordingly
  • Add code to verify CRC32 in header and payload only if option is enabled
  • Add code to compute CRC32 in Wire Protocol message send only if option is enabled

Motivation and Context

How Has This Been Tested?

  • Test app from samples repo
  • Performing usual operations in VS device manager

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: enhancement Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets labels Feb 28, 2018
@nfbot
Copy link
Member

nfbot commented Feb 28, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit dee5acc into nanoframework:develop Feb 28, 2018
@josesimoes josesimoes deleted the wireprotocol-crc32-optional branch February 28, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRC optional (needed only for unreliable transports)
2 participants