STM32 HRNG driver #642

networkfusion · 2018-03-09T16:11:57Z

Description

Most STM32's support a hardware random number generator. This PR enables this functionality

Motivation and Context

Allows more random numbers with less CPU power.
Makes Implement random number generator with hardware support Home#123 possible now.

How Has This Been Tested?

On an STM32F769I (Be aware, this is my first driver so it needs careful review against the reference implementation.

Screenshots

Types of changes

Improvement (non-breaking change that improves a feature, code or algorithm)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

nfbot · 2018-03-09T16:11:59Z

Hi @networkfusion,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

josesimoes

Looks good! Almost only cosmetic changes requested. 👏

On the code and header files, if you could tidy up the tabs... there 2 and 4 spaces... 😉

josesimoes · 2018-03-09T16:21:40Z

targets/CMSIS-OS/ChibiOS/nf-overlay/os/hal/include/stm32_rng/hal_stm32_rng.h

+
+#endif /* HAL_USE_STM32_RNG */
+
+#endif /* HAL_STM32_RNG_H_ */


missing empty line

josesimoes · 2018-03-09T16:22:45Z

targets/CMSIS-OS/ChibiOS/nf-overlay/os/hal/ports/STM32/LLD/RNGv1/README.md

@@ -0,0 +1,8 @@
+# RNG v1
+
+This driver supports all STM32 series.


this is contradicted bellow... something like all but F0 seems more accurate...

josesimoes · 2018-03-09T16:23:38Z

targets/CMSIS-OS/ChibiOS/nf-overlay/os/hal/ports/STM32/LLD/RNGv1/rng_lld.c

+
+
+uint32_t rng_lld_GetLastRandomNumber() {
+return RNGD1.RandomNumber;


missing tab

josesimoes · 2018-03-09T16:25:02Z

targets/CMSIS-OS/ChibiOS/nf-overlay/os/hal/ports/STM32/LLD/RNGv1/rng_lld.h

+
+
+// RNG Interrupt definitions
+#define RNG_IT_DRDY  RNG_SR_DRDY  /*!< Data Ready interrupt  */


RNG_SR_DRDY doesn't seem to be used anywhere

see below...

josesimoes · 2018-03-09T16:25:11Z

targets/CMSIS-OS/ChibiOS/nf-overlay/os/hal/ports/STM32/LLD/RNGv1/rng_lld.h

+#define RNG_IT_SEI   RNG_SR_SEIS  /*!< Seed error interrupt  */
+
+// RNG Flag definitions
+#define RNG_FLAG_DRDY   RNG_SR_DRDY  /*!< Data ready                 */


RNG_SR_DRDY doesn't seem to be used anywhere

That is used...

josesimoes · 2018-03-09T16:25:39Z

targets/CMSIS-OS/ChibiOS/nf-overlay/os/hal/ports/STM32/LLD/RNGv1/rng_lld.h

+
+// RNG Flag definitions
+#define RNG_FLAG_DRDY   RNG_SR_DRDY  /*!< Data ready                 */
+#define RNG_FLAG_CECS   RNG_SR_CECS  /*!< Clock error current status */


this one too

see below...

josesimoes · 2018-03-09T16:25:58Z

targets/CMSIS-OS/ChibiOS/nf-overlay/os/hal/ports/STM32/LLD/RNGv1/rng_lld.h

+// RNG Flag definitions
+#define RNG_FLAG_DRDY   RNG_SR_DRDY  /*!< Data ready                 */
+#define RNG_FLAG_CECS   RNG_SR_CECS  /*!< Clock error current status */
+#define RNG_FLAG_SECS   RNG_SR_SECS  /*!< Seed error current status  */


and this one too

I would like to keep these 3 as one is used and the other 2 are options (although not currently used...

josesimoes · 2018-03-09T16:26:17Z

targets/CMSIS-OS/ChibiOS/nf-overlay/os/hal/ports/STM32/LLD/RNGv1/rng_lld.h

+/* Driver macros.                                                            */
+/*===========================================================================*/
+// Reset RNG handle state
+//#define __RNG_RESET_HANDLE_STATE(__HANDLE__) ((__HANDLE__).State = HAL_RNG_STATE_RESET)


can be removed?

josesimoes · 2018-03-09T16:27:00Z

targets/CMSIS-OS/ChibiOS/nf-overlay/os/hal/src/stm32_rng/hal_stm32_rng.c

+  return randomNumber;
+}
+
+#endif /* HAL_USE_STM32_RNG */


missing empty line

josesimoes · 2018-03-09T16:27:44Z

targets/CMSIS-OS/ChibiOS/nf-overlay/os/hal/ports/STM32/LLD/RNGv1/rng_lld.h

+/*===========================================================================*/
+
+
+// RNG Interrupt definitions


this doesn't seem to be using interrupts so this block can go away, isn't it?

josesimoes · 2018-03-09T16:31:52Z

One last request: on the halconf_nf.h (booter and CLR) for the F091 you have to add that negative RNG driver or the build will break

networkfusion requested a review from josesimoes March 9, 2018 16:23

josesimoes requested changes Mar 9, 2018

View reviewed changes

stm32 hrng support

b2707be

josesimoes approved these changes Mar 10, 2018

View reviewed changes

Merge branch 'develop' into develop-rng

7079f56

josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets labels Mar 10, 2018

josesimoes merged commit 142c36b into nanoframework:develop Mar 10, 2018

networkfusion deleted the develop-rng branch July 24, 2018 13:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

STM32 HRNG driver #642

STM32 HRNG driver #642

networkfusion commented Mar 9, 2018 •

edited by josesimoes

Loading

nfbot commented Mar 9, 2018

josesimoes left a comment

josesimoes Mar 9, 2018

networkfusion Mar 9, 2018

josesimoes Mar 9, 2018

networkfusion Mar 9, 2018

josesimoes Mar 9, 2018

networkfusion Mar 9, 2018

josesimoes Mar 9, 2018

networkfusion Mar 9, 2018

josesimoes Mar 9, 2018

networkfusion Mar 9, 2018

josesimoes Mar 9, 2018

networkfusion Mar 9, 2018

josesimoes Mar 9, 2018

networkfusion Mar 9, 2018

josesimoes Mar 9, 2018

networkfusion Mar 9, 2018

josesimoes Mar 9, 2018

networkfusion Mar 9, 2018

josesimoes Mar 9, 2018

networkfusion Mar 9, 2018

josesimoes commented Mar 9, 2018

		@@ -0,0 +1,8 @@
		# RNG v1

		This driver supports all STM32 series.



		uint32_t rng_lld_GetLastRandomNumber() {
		return RNGD1.RandomNumber;



		// RNG Interrupt definitions
		#define RNG_IT_DRDY RNG_SR_DRDY /!< Data Ready interrupt /

		/===========================================================================/


		// RNG Interrupt definitions


		#endif /* HAL_USE_STM32_RNG */

		#endif /* HAL_STM32_RNG_H_ */

STM32 HRNG driver #642

STM32 HRNG driver #642

Conversation

networkfusion commented Mar 9, 2018 • edited by josesimoes Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

Checklist:

nfbot commented Mar 9, 2018

josesimoes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josesimoes commented Mar 9, 2018

networkfusion commented Mar 9, 2018 •

edited by josesimoes

Loading