Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on native ADC #655

Merged
merged 7 commits into from
Mar 22, 2018
Merged

Work on native ADC #655

merged 7 commits into from
Mar 22, 2018

Conversation

sjmneves
Copy link
Contributor

Description

  • Correct GetDeviceSelector
  • Amend comment on NativeGetMaxValue
  • Update assembly declarations for STM32 Windows.Devices.Adc (requires
    ADC assembly v1.0.0-preview158 or newer)
  • Update assembly declaration for ESP32 ADC functions (requires ADC
    assembly v1.0.0-preview158 or newer)
  • Add ADC configuration for ST_STM32F4_DISCOVERY
  • Add ADC configuration file to ST_STM32F4_DISCOVERY CMake target
  • Update target build configuration for ST_STM32F4_DISCOVERY to include
    ADC

Motivation and Context

  • Update native declarations for Windows.Devices.Adc
  • Implements Windows.Devices.Adc for STM32 targets

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: sjmnevessergio.neves@eclo.solutions

sjmneves and others added 6 commits March 7, 2018 11:01
- Correct GetDeviceSelector
- Amend comment on NativeGetMaxValue
- Update assembly declarations for STM32 Windows.Devices.Adc (requires
ADC assembly v1.0.0-preview158 or newer)
- Update assembly declaration for ESP32 ADC functions (requires ADC
assembly v1.0.0-preview158 or newer)
- Add ADC configuration for ST_STM32F4_DISCOVERY
- Add ADC configuration file to ST_STM32F4_DISCOVERY CMake target
- Update target build configuration for ST_STM32F4_DISCOVERY to include
ADC
@nfbot
Copy link
Member

nfbot commented Mar 22, 2018

Hi @sjmneves,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2018

CLA assistant check
All committers have signed the CLA.

@josesimoes
Copy link
Member

@AdrianSoundy this includes minor changes in ESP32 code. Could you please review them?

@josesimoes josesimoes requested a review from AdrianSoundy March 22, 2018 18:48
@josesimoes josesimoes merged commit 2d17dcd into nanoframework:develop Mar 22, 2018
@josesimoes josesimoes deleted the work-stm32-adc branch March 22, 2018 18:49
josesimoes pushed a commit to Eclo/nf-interpreter that referenced this pull request Mar 29, 2018
@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets labels Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants