-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work on native ADC #655
Merged
Merged
Work on native ADC #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correct GetDeviceSelector - Amend comment on NativeGetMaxValue
- Update assembly declarations for STM32 Windows.Devices.Adc (requires ADC assembly v1.0.0-preview158 or newer) - Update assembly declaration for ESP32 ADC functions (requires ADC assembly v1.0.0-preview158 or newer) - Add ADC configuration for ST_STM32F4_DISCOVERY - Add ADC configuration file to ST_STM32F4_DISCOVERY CMake target - Update target build configuration for ST_STM32F4_DISCOVERY to include ADC
Hi @sjmneves, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
@AdrianSoundy this includes minor changes in ESP32 code. Could you please review them? |
josesimoes
approved these changes
Mar 22, 2018
josesimoes
pushed a commit
to Eclo/nf-interpreter
that referenced
this pull request
Mar 29, 2018
josesimoes
added
Type: enhancement
Series: STM32xx
Everything related specifically with STM32 targets
Series: ESP32
Everything related specifically with ESP32 series targets
labels
Apr 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Series: ESP32
Everything related specifically with ESP32 series targets
Series: STM32xx
Everything related specifically with STM32 targets
Type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ADC assembly v1.0.0-preview158 or newer)
assembly v1.0.0-preview158 or newer)
ADC
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Signed-off-by: sjmnevessergio.neves@eclo.solutions