Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADC helper class for STM32F769I #665

Merged
merged 2 commits into from
Apr 17, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Add ADC helper class for STM32F769I
  • Update AppVeyor yaml to skip build on changes to .cs files (don't make sense in this repo as they are only helper classes)

Motivation and Context

  • Improves usability by providing C# developers working with the platform with ready to use details on the ADC configuration

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

- Update AppVeyor yaml to skip build on changes to .cs files (don't make sense in this repo as they are only helper classes)

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: enhancement FEEDBACK REQUESTED Series: STM32xx Everything related specifically with STM32 targets labels Apr 11, 2018
@nfbot
Copy link
Member

nfbot commented Apr 11, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Copy link
Member Author

Focus on STM32F769I_DISCOVERY.Adc.cs
This is my suggestion to document and provide C# developers an insight on ADC configuration for this board.

The idea would be to provide such a file for every reference board.

Plus we should have one of these for each peripheral that is not self-documenting (Serial for example, you just need to query the providers and then call the COM that you want, no need for any further details).

@steffalk
Copy link
Member

I welcome such enumerations highly, and really would see them for a) all boards supported (even if I have only a Netduino 3 so far) and b) for all things where a (newbie) developer/hobbyist would search forever for the needed information. The same is what I went through and only could succeed with the help from Peter and José about mapping a Netduino 3 I/O pin label to the actual integer number to use in C# code.

Please do include them even for cases where a µC professional wouldn't need it. Think about the entry-level hobbyists with want to start there nanoframework journey and make that start as easy as possible and as not frustrating as possible.

@josesimoes
Copy link
Member Author

@piwi1263 and @AdrianSoundy are we good with this? can it be replicated for other targets/peripherals?

@josesimoes josesimoes merged commit 1d166db into nanoframework:develop Apr 17, 2018
@josesimoes josesimoes deleted the add-adc-helper-class branch April 17, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants