Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adc-feature-for-stm32f429i-discovery #666

Merged
merged 1 commit into from
Apr 16, 2018
Merged

adc-feature-for-stm32f429i-discovery #666

merged 1 commit into from
Apr 16, 2018

Conversation

piwi1263
Copy link
Member

Description

Implement ADC feature for STM32F429I-DISCOVERY board.

  • Included ADC setup
  • Included Managed helpers
  • Included option set in build matrix

Motivation and Context

Missing feature

How Has This Been Tested?

Used sample ADC test program that outputs the ADC measured value to console and the three available user channels on PA5, PC3 and PF6 measured appropriate values for the 12 bit ADC from 0 - 4095.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: piwi1263 piwi1263@gmail.com

@piwi1263
adc-feature-for-stm32f429i-discovery
67f16d0 
Implement ADC feature for STM32F429I-DISCOVERY board.

- Include ADC setup
- Include Managed helpers
- Include option set in matrix

Signed-off-by: piwi1263 <piwi1263@gmail.com>
@nfbot
Copy link
Member

nfbot commented Apr 15, 2018

Hi @piwi1263,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@piwi1263 piwi1263 requested a review from josesimoes April 15, 2018 22:44
@piwi1263 piwi1263 added Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets Series: STM32xx Everything related specifically with STM32 targets labels Apr 15, 2018
josesimoes
josesimoes approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes added Type: enhancement and removed Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets labels Apr 16, 2018
@josesimoes josesimoes merged commit 391b955 into nanoframework:develop Apr 16, 2018
@josesimoes
Copy link
Member

@piwi1263 when you have the time, please add the ✔️ to the ADC row for the F429I (readme in this repo and Home too)

@piwi1263
Copy link
Member Author

Update concerning those check marks done. That completes the feature set for the STM32F429I-DISCOVERY.

@piwi1263 piwi1263 deleted the adc-4-429 branch April 16, 2018 10:05
@piwi1263 piwi1263 restored the adc-4-429 branch April 16, 2018 16:45
@piwi1263 piwi1263 deleted the adc-4-429 branch April 16, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piwi1263 @nfbot @josesimoes