Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ADC feature for ST_NUCLEO_F746ZG board #667

Merged
merged 1 commit into from
Apr 17, 2018
Merged

Implement ADC feature for ST_NUCLEO_F746ZG board #667

merged 1 commit into from
Apr 17, 2018

Conversation

piwi1263
Copy link
Member

@piwi1263 piwi1263 commented Apr 16, 2018

Description

Implement ADC feature for ST_NUCLEO_F746ZG board.

  • Include ADC setup
  • Include Managed helpers
  • Include option set in matrix
  • Include check mark for feature table

Motivation and Context

Missing feature

How Has This Been Tested?

Used sample ADC test program that outputs the ADC measured value to console and all but one available user channel do work. A0, A2, A3, A4, A5, A6, A7 and A8 do all function. Only A1 does not. A seperate issue will be created to follow up on the not functioning channel.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: piwi1263 piwi1263@gmail.com

@nfbot
Copy link
Member

nfbot commented Apr 16, 2018

Hi @piwi1263,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@piwi1263 piwi1263 requested a review from josesimoes April 16, 2018 21:36
@piwi1263 piwi1263 added Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets Series: STM32xx Everything related specifically with STM32 targets labels Apr 16, 2018
@josesimoes josesimoes added Type: enhancement and removed Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets labels Apr 16, 2018
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes
Copy link
Member

For some reason your hashtag with the board name is confusing AppVeyor. Could you please amend the commit message and remove that? As you are at it, also correct the message: it's referring to F249 instead of F746. 😉

@piwi1263
Copy link
Member Author

Done.

Implement ADC feature for ST_NUCLEO_F746ZG board.

- Include ADC setup
- Include Managed helpers
- Include option set in matrix
- Include check mark for feature table

Signed-off-by: piwi1263 <piwi1263@gmail.com>
@josesimoes josesimoes merged commit e0bba00 into nanoframework:develop Apr 17, 2018
@josesimoes josesimoes changed the title adc-feature-for-nucleo-f746zg Implement ADC feature for ST_NUCLEO_F746ZG board Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants