Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct calls to cache helpers for STM32 targets #676

Merged
merged 1 commit into from
May 3, 2018
Merged

Correct calls to cache helpers for STM32 targets #676

merged 1 commit into from
May 3, 2018

Conversation

josesimoes
Copy link
Member

Description

  • The wrong cache helper function were being called on some locations
  • Correct comments

Motivation and Context

  • Fix potential issues with cache enabled targets (STM32F7 & H7)

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@josesimoes
Correct calls to cache helpers for STM32 targets
26c30cd 
- The wrong cache helper function were being called on some locations
- Correct comments

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets labels May 3, 2018
@nfbot
Copy link
Member

nfbot commented May 3, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 2c234bd into nanoframework:develop May 3, 2018
@josesimoes josesimoes deleted the fix-cache-issues-smt32f7 branch May 3, 2018 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot