Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RTC SetSystemTime #684

Merged
merged 2 commits into from
May 14, 2018
Merged

Implement RTC SetSystemTime #684

merged 2 commits into from
May 14, 2018

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented May 14, 2018 •
edited by josesimoes
Loading

Description

Adds the missing code to support the setting of the System Date Time

Motivation

How Has This Been Tested?

Tested with application that first sets Date/Time and then does console.writeline( DateTime.utcNow.tostring() )
And checked the date time was correct.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@nfbot
Copy link
Member

nfbot commented May 14, 2018

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Type: enhancement Series: ESP32 Everything related specifically with ESP32 series targets labels May 14, 2018
@josesimoes josesimoes merged commit fabc6b6 into nanoframework:develop May 14, 2018
@josesimoes josesimoes mentioned this pull request May 14, 2018
Closed
@AdrianSoundy AdrianSoundy deleted the develop-setdatetime branch May 15, 2018 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement nanoFramework.Runtime.Native for ESP32
3 participants
@AdrianSoundy @nfbot @josesimoes