Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General improvements in STM32 USB code #689

Merged
merged 3 commits into from
May 16, 2018
Merged

General improvements in STM32 USB code #689

merged 3 commits into from
May 16, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Replaced chnReadTimeout/Write with streamRead/Write
  • Improve ReceiverThread by not launching the receive loop if USB is not connected
  • Replace osDelay with osThreadYield in ReceiverThread
  • Correct defines in USB config on several targets
  • Improve USB_EVENT_CONFIGURED @ usb_event
  • Replace direct call to sduRequestsHook with requests_hook

Motivation and Context

  • General improvements in USB layer
  • Possible fix for board hang when USB cable is connected

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@josesimoes
General improvements in STM32 USB code
e4d1a14 
- Replaced chnReadTimeout/Write with streamRead/Write
- Improve ReceiverThread by not launching the receive loop if USB is not connected
- Replace osDelay with osThreadYield in ReceiverThread
- Correct defines in USB config on several targets
- Improve USB_EVENT_CONFIGURED @ usb_event
- Replace direct call to sduRequestsHook with requests_hook

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets labels May 16, 2018
@nfbot
Copy link
Member

nfbot commented May 16, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes force-pushed the improvements-stm32-usb-code branch from d34fda9 to 0f693dd Compare May 16, 2018 18:31
@josesimoes josesimoes merged commit 907bcc7 into nanoframework:develop May 16, 2018
@josesimoes josesimoes deleted the improvements-stm32-usb-code branch May 16, 2018 20:29
@josesimoes josesimoes mentioned this pull request May 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot