Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ESP32 Gpio toggle #703

Merged
merged 1 commit into from
May 25, 2018
Merged

Fix ESP32 Gpio toggle #703

merged 1 commit into from
May 25, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Fix ESP32 Gpio toggle
  • Add code to store last output value on Init and Write (wasn't being set)

Motivation and Context

  • Correct bug with toggling Gpio: reading pin doesn't provide the current output value

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@josesimoes
Fix ESP32 Gpio toggle
ed1a42e 
- Correct bug with toggling Gpio: reading pin doesn't provide the current output value
- Add code to store last output value on Init and Write (wasn't being set)

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Series: ESP32 Everything related specifically with ESP32 series targets labels May 25, 2018
@nfbot
Copy link
Member

nfbot commented May 25, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit f313565 into nanoframework:develop May 25, 2018
@josesimoes josesimoes deleted the fix-esp32-toggle branch May 25, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot