Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI: Use the max clock frequency if unset (#327) #711

Merged
merged 1 commit into from
May 29, 2018
Merged

SPI: Use the max clock frequency if unset (#327) #711

merged 1 commit into from
May 29, 2018

Conversation

MatthiasJentsch
Copy link
Contributor

@MatthiasJentsch MatthiasJentsch commented May 29, 2018

Description

Fixing "Getting 'System.ArgumentException' Error while calling 'SpiDevice.FromId'". The cause of this exception is the unset SPI clock frequency. Now if the frequency is unset we use the max frequency.

Motivation and Context

How Has This Been Tested?

Tested on ESP32 with the following C# code:
SpiDevice.FromId("SPI1", new SpiConnectionSettings(22));

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Matthias Jentsch info@matthias-jentsch.de

Fixing "Getting 'System.ArgumentException' Error while calling 'SpiDevice.FromId'". The cause of this exception is the unset SPI clock frequency. Now if the frequency is unset we use the max frequency.

Signed-off-by: Matthias Jentsch <info@matthias-jentsch.de>
@nfbot
Copy link
Member

nfbot commented May 29, 2018

Hi @MatthiasJentsch,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes requested a review from AdrianSoundy May 29, 2018 20:34
@josesimoes josesimoes added Type: bug Series: ESP32 Everything related specifically with ESP32 series targets labels May 29, 2018
Copy link
Member

@AdrianSoundy AdrianSoundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting 'System.ArgumentException' Error while calling 'SpiDevice.FromId'
4 participants