Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial ESP32 native hardware support #712

Merged
merged 2 commits into from
May 30, 2018
Merged

Initial ESP32 native hardware support #712

merged 2 commits into from
May 30, 2018

Conversation

AdrianSoundy
Copy link
Member

Description

This adds an interface so native ESP32 functions that are not included in normal UWP assemblies can be called from managed code.

  • Call the ESP32 Sleep functions.
  • Change the IDF logging options.

Motivation and Context

Required as no functions in UWP assemblies to call these functions

Types of changes

  • [] Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@nfbot
Copy link
Member

nfbot commented May 30, 2018

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Seems like a great addition to the API! 👏

Copy link
Contributor

@MatthiasJentsch MatthiasJentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general that looks also good to me, but the build is failing.

Comment message output
@AdrianSoundy AdrianSoundy merged commit cbbf357 into nanoframework:develop May 30, 2018
@AdrianSoundy AdrianSoundy deleted the develop-hardware branch May 30, 2018 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants